Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify NTLM event fields to capture failed NTLM attemp #90

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Conversation

jknpark
Copy link
Collaborator

@jknpark jknpark commented Dec 27, 2023

Related issue: aicers/piglet#573
Merge before aicers/piglet#707

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (9c444ed) 33.69% compared to head (d22de45) 33.64%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/ingest/network.rs 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   33.69%   33.64%   -0.06%     
==========================================
  Files          13       13              
  Lines         650      651       +1     
==========================================
  Hits          219      219              
- Misses        431      432       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jknpark jknpark requested a review from msk December 27, 2023 04:21
@jknpark jknpark merged commit b133b79 into main Jan 2, 2024
8 checks passed
@jknpark jknpark deleted the ntlm branch January 2, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants